Skip to content

fix: Edit payments fields #431 #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2021
Merged

fix: Edit payments fields #431 #436

merged 3 commits into from
Jul 31, 2021

Conversation

@yoution
Copy link
Contributor

@yoution yoution commented Jul 28, 2021

@maxceem please review

maxceem
maxceem suggested changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution in general works good, but there are a few small issues. Please check the comments below.

@yoution yoution requested a review from maxceem July 29, 2021 15:40
maxceem
maxceem approved these changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution works good, just had to adjust the formula to:

const maxPossibleDays = correspondingWorkPeriod.daysWorked - (correspondingWorkPeriod.daysPaid - oldValue.days)

@maxceem maxceem merged commit 81a3112 into topcoder-platform:dev Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maxceem maxceem maxceem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoution @maxceem